Include dpctl4pybind11.hpp in dpnp4pybind11.hpp and switch libtensor to dpnp namespace#2862
Merged
antonwolfy merged 10 commits intoinclude-dpctl-tensorfrom Apr 20, 2026
Merged
Conversation
include dpctl4pybind11.hpp and remove redundant code
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
ndgrigorian
changed the title
dpctl4pybind11.hpp in dpnp4pybind11.hppdpctl4pybind11.hpp in dpnp4pybind11.hpp and switch libtensor to dpnp namespace
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev6=py313h509198e_69 ran successfully. |
array unused, stddef.h not used because size_t is never used with C linkage
ndgrigorian
force-pushed
the
further-refactor-dpnp4pybind11
branch
from
7d4b95f to
ffa9268
Compare
Collaborator
Author
|
This PR can be split to implement the namespace changes in a follow-up, only the first 3 commits (and the part about adding back but regardless, it should go in before migration is complete @antonwolfy @vlad-perevezentsev |
test slowdown was likely caused by their removal
also add a TODO for reusing a future, more general keep_args_alive from dpctl
antonwolfy
reviewed
Apr 20, 2026
antonwolfy
approved these changes
Apr 20, 2026
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian , no more comments from me
Contributor
|
The CI failures seems unrelating, so merging |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes including
dpctl4pybind11.hppindpnp4pybind11.hpp.dpnp4pybind11.hppis still using the dpctl namespace, the reimplementations could potentially cause code using bothdpctl4pybind11.hppanddpnp4pybind11.hpptogether to crash due to multiple definitions in one translation unit. This can be problematic when both libraries are attempting to expose headers, with dpnp depending directly on dpctlAs part of this change, this PR also changes the
dpctlnamespace in libtensor todpnp